Re: commit: fixes encoding problems in win32

From: Dom Lachowicz (
Date: Tue Dec 09 2003 - 14:11:47 EST

  • Next message: Marc Maurer: "Commit (HEAD): Revert: Re: commit: fixes encoding problems in win32"

    Hi Jordi,

    I really appreciate your work here. But I don't think
    that the approach you just took is the correct one,
    and as such, I think that it's preferable to revert
    your patch.

    Ideally, all of our filenames will be in UTF-8 or some
    other well-known, unicode encoding. The proper
    solution, IMO, is to convert from the native OS'
    encoding into UTF8 at boundary conditions. Namely, at
    least these two places:

    Command Line
    File Dialog
    Loading of additional files (HTML <img>, for example)

    During save, we'll have to convert the UTF8 into the
    native encoding in order for fopen() to work properly.

    I think that your code here is a kludge, but
    illustrates a very real problem that we need to solve
    and a problem that we intend to solve (it's already on
    the 2.2 roadmap). As such, I'm asking Marc to please
    revert this patch.

    Best regards,

    --- Jordi Mas <> wrote:
    > CVS:
    > CVS: Enter Log. Lines beginning with `CVS:' are
    > removed automatically
    > CVS:
    > CVS: Committing in .
    > CVS:
    > CVS: Modified Files:
    > CVS: src/af/xap/xp/xap_FrameImpl.cpp
    > src/af/xap/xp/xap_Prefs.cpp
    > CVS: src/wp/ap/win/ap_Win32App.cpp
    > CVS:
    > This fixes allow:
    > - To save and load filenames with international
    > chars (were saved
    > incorrectly in the prefs file before)
    > - To display filenames with international chars
    > correctly in the
    > application bar
    > Jordi,
    > Note: Please, backport to STABLE.
    > --
    > Jordi Mas i Hernāndez (homepage

    Do you Yahoo!?
    Protect your identity with Yahoo! Mail AddressGuard

    This archive was generated by hypermail 2.1.4 : Tue Dec 09 2003 - 14:10:44 EST