Re: POW 19.12.99 questions

Subject: Re: POW 19.12.99 questions
From: Mike Nordell (
Date: Wed May 17 2000 - 08:32:34 CDT

Alexey Sintutin wrote:

> 1. I draw tab arrows using the polyLine method, which has no the Color
> argument. What do you think is better, to add a new polyLine method
> with the Color argument (Polygon) or to draw arrows using bitmaps?

I think that _drawing_ the arrows is to prefer (bitmaps usually looks bad
when scaled).

About the line color, I think an extra method to the painter is the way
to do it. Rationale: Adding default arguments, that only are used
once-in-a-while, is IMO waste. It could probably be added to my answer to
#3 below.

> 2. I did not begin to write a new class for the Paragraph Break run,
> but there is an easier decision: to add the Paragraph Break sign after
> last run of every last paragraph line (see the following sample code).
> What is your opinion about the decision? Is it good? Can we use it
> until the Paragraph Break run has been written?

Seems OK to me.

> 3. I think it will good if we will create the drawLine method with the
> PenStyle argument, which draws solid, dotted, dashed, etc. lines. The
> method permit us to vary the editor with dotted column break line, etc.
> What do you think?

I'd say that this one is harder to make a design decision about. Since
the usual case is probably quite simple on every platform, but the
PenStyle case is probably a bit more code to run through, I'd say we go
for an overloaded method with extra argument(s). The mentioned color
argument could also be added to this new method.

> 4. A selection rectangle is higher and wider than a line on one pixel
> and Ihave to draw column boundaries higher and wider then column
> sise on 2 pixels. Is the size of selection rectangle correct? If no, I
> am ready to change size of selection rectangle and correct the POW

I'm not up-to-date on that POW, but to have the selection rectangle
inflated by one pixel seems to me the way to go. It might even have to be
inflated two or more pixels to look good at higher resolutions, but that
should be a minor issue.

Looking at UT_Rect from "ut_misc.h" I see that the methods
inflate/deflate are missing from it. They should probably be added (I'd
do it right now if I weren't way too deep in "Cursor as its own entity").

/Mike - please reply to AbiWord-dev only

This archive was generated by hypermail 2b25 : Wed May 17 2000 - 07:31:23 CDT