Re: joehe - r33361 - abiword/branches/gsoc2013tables/src/text/fmt/xp

On 07/08/13 10:40 AM, cvs@abisource.com wrote:
> Modified: abiword/branches/gsoc2013tables/src/text/fmt/xp/fl_TableLayout.cpp
> ===================================================================
> --- abiword/branches/gsoc2013tables/src/text/fmt/xp/fl_TableLayout.cpp 2013-08-06 17:55:49 UTC (rev 33360)
> +++ abiword/branches/gsoc2013tables/src/text/fmt/xp/fl_TableLayout.cpp 2013-08-07 14:40:18 UTC (rev 33361)
> @@ -1686,7 +1686,7 @@
> s_background_properties (pszBgStyle, pszBgColor, pszBackgroundColor, m_background);
>
> //Table header
> - char * pszTableHeader = NULL;
> + char pszTableHeader[1024];
>
> pSectionAP->getProperty("header",(const gchar *&)pszTableHeader);

I don't get why you changed the declaration of pszTableHeader. This is
actually bad because getProperty() will put a pointer into it.

Check the code in PP_AttrProp::getProperty() if you don't understand.

Hub
Received on Wed Aug 7 17:59:11 2013