Re: errors in previous patch

Subject: Re: errors in previous patch
From: Martin Sevior (
Date: Wed Mar 28 2001 - 02:49:02 CST

Hi Patrick,
          Thanks very much for this. Please send a new patch against the
very latest CVS please. From looking at just the patch you appear to be
hardwiring the color of the leaders chars to black and are actually
drawing the leaders during a clearScreen. Is this correct?

You should set the leader char color to the current foreground color (see
the _drawParts method in fp_TextRun.cpp).

I'm not sure that drawing the leaders in the clearScreen is the right
thing to do. It probabally won't print and we may get character dirt.

Anyway, thanks very much for your work so far, please send a new patch.



On Wed, 28 Mar 2001, Patrick Lam wrote:

> Oops, I forgot to remove some debugging code. Should I send a new patch?
> The diff to fp_Run.cpp should modify line 753 to
> + if (m_leader != FL_LEADER_NONDE)
> and further down, the default: case should set tmp[1] to ' ', not 'q'.
> pat

This archive was generated by hypermail 2b25 : Wed Mar 28 2001 - 02:49:17 CST