Subject: Re: BiDi patch
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Mon Jan 22 2001 - 15:08:09 CST
On Mon, 22 Jan 2001, Thomas Fletcher wrote:
> On Mon, 22 Jan 2001, Martin Sevior wrote:
>
> > OK from just a little playing I cannot find anything wrong. I'll try more
> > tests tomorrow. I am getting tons and tons of debug information and
> > asserts though. The assets are:
> >
> > **** (1489) src at ut_string.cpp:1056 ****
> > **** (1489) Continue ? (y/n) [y] :
> > **** (1490) Assert ****
> > **** (1490) lenSpan>0 at fp_TextRun.cpp:1173 ****
> > **** (1490) Continue ? (y/n) [y] :
> > **** (1491) Assert ****
> > **** (1491) src at ut_string.cpp:1056 ****
> > **** (1491) Continue ? (y/n) [y] :
> >
> > Can I comment hem out? They trigger VERY frquently.
>
> The asserts are there for a reason ... why are they triggering? I
> would suspect that we should check the inputs to the ut_string code
> since we shouldn't be calling it with NULL strings in any case.
>
These asserts are in code specifically placed inside
#ifdef bidi_enabled
..
#endif
constructs. ie Tomas put in both the code in ut-Strings.cpp and whatever
triggers the asserts. I am also confused as to why src can be NULL and we
don't get crashes. I was hoping to save some myself some work by asking
Tomas to explain...
Martin
This archive was generated by hypermail 2b25 : Mon Jan 22 2001 - 15:08:27 CST