Subject: Re: BiDi patch
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Mon Jan 22 2001 - 01:31:16 CST
On Sat, 13 Jan 2001, Tomas Frydrych wrote:
>
> There are two issues here. (1) the patch currently implements only
> the the core changes, and thus works only with the ABW native
> format; the importers/exporters will have to be modified to handle
> the two new properties called 'direction' and 'dominant-direction'. (2)
> The last patch I made was in test mode in which capitals are
> treated as RTL characters; this was an oversight, to fix it just
> comment out #define CAPS_TEST near the top of fp_TextRun.cpp
> and recompile, hopefully you should see your doc OK. (I should
> say that only the first character of each run is tested, since runs of
> different direction cannot be coalesced, so that you almost
> certainly see even lowercase characters reversed in your document
> in the test mode.)
>
OK from just a little playing I cannot find anything wrong. I'll try more
tests tomorrow. I am getting tons and tons of debug information and
asserts though. The assets are:
**** (1489) src at ut_string.cpp:1056 ****
**** (1489) Continue ? (y/n) [y] :
**** (1490) Assert ****
**** (1490) lenSpan>0 at fp_TextRun.cpp:1173 ****
**** (1490) Continue ? (y/n) [y] :
**** (1491) Assert ****
**** (1491) src at ut_string.cpp:1056 ****
**** (1491) Continue ? (y/n) [y] :
Can I comment hem out? They trigger VERY frquently.
I also get tons of debug info when whenever I move the mouse over the
document like these.
DEBUG: BlockLayout::FindPointCoords: iPos=984, dPos=863
DEBUG: BlockLayout::FindPointCoords: iPos=984, dPos=863
DEBUG: BlockLayout::FindPointCoords: iPos=984, dPos=863
DEBUG: BlockLayout::FindPointCoords: iPos=984, dPos=863
I'd like to comment these out too.
Nothing obviously wrong yet. Speed seems OK but it is hard to tell with
all those asserts and debug info.
Martin
This archive was generated by hypermail 2b25 : Mon Jan 22 2001 - 01:31:31 CST