Subject: Re: fix for iconv related crash
From: Dom Lachowicz (cinamod@hotmail.com)
Date: Wed Jan 03 2001 - 10:02:37 CST
Fix bug reported by Alec Wolman
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: xp/xap_EncodingManager.cpp
CVS: ----------------------------------------------------------------------
>From: "Alec Wolman" <wolman@cs.washington.edu>
>To: abiword-dev@abisource.com
>Subject: fix for iconv related crash
>Date: Tue, 02 Jan 2001 19:16:44 -0800
>
>When running AbiWord, I get a crash in iconv_close() called by
>the XAP_EncodingManager destructor.
>have been introduced by the Nov 27th checkin by "dom". Here is
>the quick summary: when iconv_open fails, it returns -1 (not 0).
>The destructor checks to see if the handle is non-NULL, and if
>so it calls the close() routine. Thus the crash.
>
>This problem seems to have been introduced by a checkin on Nov 27th
>by Dom. My simple fix is to change all
>the occurences in XAP_EncodingManager::~XAP_EncodingManager() of
>
> if (iconv_handle_foo)
>
>to
>
> if (iconv_handle_foo != (iconv_t)-1)
>
>
>Alec
>
_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com
This archive was generated by hypermail 2b25 : Wed Jan 03 2001 - 10:02:39 CST