Subject: Re: Patch for bug 787
From: Thomas Briggs (email@example.com)
Date: Thu Sep 07 2000 - 07:49:46 CDT
> Last month, Saint-Denis posted  a patch to fix bug 787, which deals
> with Windows installer issues. Again, this applies cleanly, so if someone
> with a windows machine is willing to test it, it can get committed.
I looked at this patch closely, because I'd been working on fixing this
same bug shortly before the patch was committed. I didn't commmit the patch
for two reasons:
1. I was never able to reproduce the stated problem (can't install to a
drive other than c:)
2. Even after applying the patch, the install path used by and displayed
in the installer has double slashes in it if you select a drive other than
c: (D:\\AbiWord, for example), which though it doesn't cause any problems
doesn't look right.
I don't think I've ever seen anybody shoot down a patch, but in this
case, as much as I hate to do so, I don't think this should be applied. If
somebody else can reproduce the stated problem and confirm that the patch
fixes it, I'll commit it. A this point, however, I just don't see any sense
in doing so, as it doesn't seem to solve any problems for me.
> Additionally, Saint-Denis made a few suggestions in his message for fixing
> bug 710, in which we blatantly disregard the actual terms of the GPL. I
> like all of them, and will creat a patch if (s)he doesn't want to.
I noted the rest of the comments in that post with interest, and intend
to make use of them (assuming somebody else doesn't beat me to it). So
these suggestions haven't been lost or forgetting about.
Unfortunately, MyDayJob[tm] has kept me from spending much time on Abi
over the last couple months, so I don't have anything to show in regards to
the above stuff. I'm on vacation next week, so maybe I'll find some time
then (translation: if my wife lets me. :P)
This archive was generated by hypermail 2b25 : Thu Sep 07 2000 - 07:49:07 CDT