Re: Independant Insert Picture Dialog

Subject: Re: Independant Insert Picture Dialog
From: Aaron Lehmann (
Date: Wed Jun 28 2000 - 01:59:51 CDT

I would like to check this out, but it won't apply to my copy since your
patch has Windows lineendings. I would like to remind people to please use
CVS to make diffs - it makes it much easier for both the people who make
the diffs and those who apply them. Anyway, I'm in a good mood, so here's
a simple tutorial on how to make diffs using CVS:

* Do your work on the source code, which you just checked out of CVS.
Instructions for checking out source code using CVS are on the AbiWord
developer page. If it's a long-term project, make sure to 'cvs update'
often. There's no need to keep a backup copy.

* When you're finished with your changes and want to produce a diff, run
'cvs update' to merge in any recent changes from CVS. Reslove any
conflicts that arise. Type 'cvs diff -u > myfile.diff' to produce a diff
file vs. CVS.

That's it! Anyway, I would like to politely request that people always use
this method since it makes sure that the patches produced apply to the
current version of the tree and should resolve any problems with
linebreaks as well. Though I may seem frustrated, I'm not trying to flame.
I am looking forward to trying out your patches (which look promissing)
and possibly porting your changes to UNIX.

Aaron Lehmann

P.S. Should we put a simple guide like this to diffing with CVS on the
webpage with the CVS checkout instructions?

On Tue, 27 Jun 2000, Michael D. Pritchett wrote:

> In an effort to extend the Insert_Picture dialog in Windows to include a
> preview feature, I needed to create a independant dialog instead of re-using
> the XAP_DIALOG_ID_FILE_OPEN of FileOpenSaveAs Dialog.
> This patch adds the XAP_DIALOG_ID_INSERT_PICTURE of FileOpenSaveAs dialog
> and all appropriate stubs so as to not break other builds (I hope). It does
> require a clean build to catch the changes made to the header file. I have
> only checked it on Win32 systems.
> Cheers!
> Michael D. Pritchett
> newbie

This archive was generated by hypermail 2b25 : Wed Jun 28 2000 - 02:00:29 CDT